From 708bd7920060c02a02c62c9bd94a8be5716a7477 Mon Sep 17 00:00:00 2001
From: br0kenpixel <23280129+br0kenpixel@users.noreply.github.com>
Date: Sat, 8 Nov 2025 14:06:51 +0100
Subject: [PATCH] fix: simplify error handling for `FetchError` in various
 components

---
 frontend/app/pages/account/activation/[token].vue         | 2 +-
 .../app/pages/dashboard/admin/internships/edit/[id].vue   | 2 +-
 frontend/app/pages/dashboard/admin/students/edit/[id].vue | 3 ---
 .../app/pages/dashboard/student/internship/create.vue     | 7 +++++--
 frontend/app/pages/login.vue                              | 2 +-
 frontend/app/pages/register/company.vue                   | 7 +++++--
 frontend/app/pages/register/student.vue                   | 7 +++++--
 frontend/app/pages/reset_psw/index.vue                    | 8 ++++++--
 8 files changed, 24 insertions(+), 14 deletions(-)

diff --git a/frontend/app/pages/account/activation/[token].vue b/frontend/app/pages/account/activation/[token].vue
index 45edf0d..f083598 100644
--- a/frontend/app/pages/account/activation/[token].vue
+++ b/frontend/app/pages/account/activation/[token].vue
@@ -43,7 +43,7 @@ async function handleLogin() {
 
         success.value = true;
     } catch (e) {
-        if (e instanceof FetchError && e.response?.status === 422) {
+        if (e instanceof FetchError) {
             error.value = e.response?._data.message;
         }
     } finally {
diff --git a/frontend/app/pages/dashboard/admin/internships/edit/[id].vue b/frontend/app/pages/dashboard/admin/internships/edit/[id].vue
index 6b9c4cc..f74d4e2 100644
--- a/frontend/app/pages/dashboard/admin/internships/edit/[id].vue
+++ b/frontend/app/pages/dashboard/admin/internships/edit/[id].vue
@@ -33,7 +33,7 @@ async function handleUpdateOfBasicInfo(internship: NewInternship) {
 
         navigateTo("/dashboard/admin/internships");
     } catch (e) {
-        if (e instanceof FetchError && (e.response?.status === 422 || e.response?.status === 400)) {
+        if (e instanceof FetchError) {
             action_error.value = e.response?._data.message;
         }
     } finally {
diff --git a/frontend/app/pages/dashboard/admin/students/edit/[id].vue b/frontend/app/pages/dashboard/admin/students/edit/[id].vue
index 72c3bb7..2a668a6 100644
--- a/frontend/app/pages/dashboard/admin/students/edit/[id].vue
+++ b/frontend/app/pages/dashboard/admin/students/edit/[id].vue
@@ -64,7 +64,6 @@ async function saveChanges() {
         navigateTo("/dashboard/admin/students");
     } catch (e) {
         if (e instanceof FetchError) {
-            console.error('Error saving student:', e.response?._data.message);
             alert('Chyba:\n' + e.response?._data.message);
         }
     } finally {
@@ -111,8 +110,6 @@ const deleteStudent = async () => {
     } catch (e) {
         if (e instanceof FetchError) {
             deleteError.value = e.response?._data?.message || 'Chyba pri mazaní študenta.';
-        } else {
-            deleteError.value = 'Neznáma chyba pri mazaní študenta.';
         }
     } finally {
         deleteLoading.value = false;
diff --git a/frontend/app/pages/dashboard/student/internship/create.vue b/frontend/app/pages/dashboard/student/internship/create.vue
index acd2b46..cf349da 100644
--- a/frontend/app/pages/dashboard/student/internship/create.vue
+++ b/frontend/app/pages/dashboard/student/internship/create.vue
@@ -1,5 +1,6 @@
 <script setup lang="ts">
 import type { NewInternship } from '~/types/internships';
+import { FetchError } from 'ofetch';
 
 definePageMeta({
     middleware: ['sanctum:auth', 'student-only'],
@@ -25,8 +26,10 @@ async function handleInternshipRegistration(internship: NewInternship) {
         });
 
         navigateTo("/dashboard/student");
-    } catch (e: any) {
-        error.value = e.data?.message as string;
+    } catch (e) {
+        if (e instanceof FetchError) {
+            error.value = e.response?._data.message;
+        }
     } finally {
         loading.value = false;
     }
diff --git a/frontend/app/pages/login.vue b/frontend/app/pages/login.vue
index d079505..0b7899c 100644
--- a/frontend/app/pages/login.vue
+++ b/frontend/app/pages/login.vue
@@ -35,7 +35,7 @@ async function handleLogin() {
     try {
         await login(form.value);
     } catch (e) {
-        if (e instanceof FetchError && e.response?.status === 422) {
+        if (e instanceof FetchError) {
             error.value = e.response?._data.message;
         }
     } finally {
diff --git a/frontend/app/pages/register/company.vue b/frontend/app/pages/register/company.vue
index 8137aad..b0fbb38 100644
--- a/frontend/app/pages/register/company.vue
+++ b/frontend/app/pages/register/company.vue
@@ -1,6 +1,7 @@
 <script setup lang="ts">
 import { NewRole } from '~/types/role';
 import type { NewUser } from '~/types/user';
+import { FetchError } from 'ofetch';
 
 definePageMeta({
     middleware: ['sanctum:guest'],
@@ -63,8 +64,10 @@ async function handleRegistration() {
         });
 
         navigateTo("/");
-    } catch (e: any) {
-        error.value = e.data?.message as string;
+    } catch (e) {
+        if (e instanceof FetchError) {
+            error.value = e.response?._data.message;
+        }
     } finally {
         loading.value = false;
     }
diff --git a/frontend/app/pages/register/student.vue b/frontend/app/pages/register/student.vue
index 9b47696..29b530e 100644
--- a/frontend/app/pages/register/student.vue
+++ b/frontend/app/pages/register/student.vue
@@ -1,6 +1,7 @@
 <script setup lang="ts">
 import { NewRole } from '~/types/role';
 import type { NewUser } from '~/types/user';
+import { FetchError } from 'ofetch';
 
 definePageMeta({
     middleware: ['sanctum:guest'],
@@ -71,8 +72,10 @@ async function handleRegistration() {
         });
 
         navigateTo("/");
-    } catch (e: any) {
-        error.value = e.data?.message as string;
+    } catch (e) {
+        if (e instanceof FetchError) {
+            error.value = e.response?._data.message;
+        }
     } finally {
         loading.value = false;
     }
diff --git a/frontend/app/pages/reset_psw/index.vue b/frontend/app/pages/reset_psw/index.vue
index 644736e..c2ea24f 100644
--- a/frontend/app/pages/reset_psw/index.vue
+++ b/frontend/app/pages/reset_psw/index.vue
@@ -1,4 +1,6 @@
 <script setup lang="ts">
+import { FetchError } from 'ofetch';
+
 const client = useSanctumClient();
 
 definePageMeta({
@@ -36,8 +38,10 @@ async function handleReset() {
         });
 
         navigateTo("/reset_psw/request_sent");
-    } catch (e: any) {
-        error.value = e.data?.message as string;
+    } catch (e) {
+        if (e instanceof FetchError) {
+            error.value = e.response?._data.message;
+        }
     } finally {
         loading.value = false;
     }