br0kenpixel/isop-mirror
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: rename agreement to proof

Browse Source
This commit is contained in:
Fábián Varga
2025-11-29 14:56:33 +01:00
parent 5b84b67a65
commit 6801132921
10 changed files with 57 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
backend/app/Http/Controllers/InternshipController.php
View File

@@ -61,7 +61,7 @@ class InternshipController extends Controller
return response()->json($internship);
}
public function get_default_agreement(Request $request, int $id)
public function get_default_proof(Request $request, int $id)
{
$user = auth()->user();
$internship = Internship::find($id);
@@ -78,7 +78,7 @@ class InternshipController extends Controller
$contact = User::find($internship->company->contact);
$html = view('agreement.default', [
$html = view('proof.default', [
'company' => $internship->company,
'companyContact' => $contact,
'internship' => $internship,
@@ -93,10 +93,10 @@ class InternshipController extends Controller
return response($pdf->Output('', 'S'), 200)
->header('Content-Type', 'application/pdf')
->header('Content-Disposition', 'attachment; filename="agreement_' . $id . '.pdf"');
->header('Content-Disposition', 'attachment; filename="proof_' . $id . '.pdf"');
}
public function get_agreement(int $id)
public function get_proof(int $id)
{
$user = auth()->user();
$internship = Internship::find($id);
@@ -107,9 +107,9 @@ class InternshipController extends Controller
], 400);
}
if (!$internship->agreement) {
if (!$internship->proof) {
return response()->json([
'message' => 'No agreement file exists for this internship.'
'message' => 'No proof file exists for this internship.'
], 404);
}
@@ -117,9 +117,9 @@ class InternshipController extends Controller
abort(403, 'Unauthorized');
}
return response($internship->agreement, 200)
return response($internship->proof, 200)
->header('Content-Type', 'application/pdf')
->header('Content-Disposition', 'attachment; filename="agreement_' . $id . '.pdf"');
->header('Content-Disposition', 'attachment; filename="proof_' . $id . '.pdf"');
}
public function get_report(int $id)
@@ -182,7 +182,7 @@ class InternshipController extends Controller
'year_of_study' => $request->year_of_study,
'semester' => $request->semester,
'position_description' => $request->position_description,
'agreement' => null
'proof' => null
]);
InternshipStatusData::create([
@@ -250,13 +250,13 @@ class InternshipController extends Controller
}
$request->validate([
'agreement' => ['nullable', 'file', 'mimes:pdf', 'max:10240'],
'proof' => ['nullable', 'file', 'mimes:pdf', 'max:10240'],
'report' => ['nullable', 'file', 'mimes:pdf', 'max:10240'],
'report_confirmed' => ['required', 'boolean'],
]);
if ($request->hasFile('agreement')) {
$internship->agreement = file_get_contents($request->file('agreement')->getRealPath());
if ($request->hasFile('proof')) {
$internship->proof = file_get_contents($request->file('proof')->getRealPath());
}
if ($request->hasFile('report')) {
@@ -264,9 +264,9 @@ class InternshipController extends Controller
}
if ($user->role === 'EMPLOYER') {
if ($request->report_confirmed && (!$internship->agreement || !$internship->report)) {
if ($request->report_confirmed && (!$internship->proof || !$internship->report)) {
return response()->json([
'message' => 'Report cannot be confirmed without an agreement and report.'
'message' => 'Report cannot be confirmed without an proof and report.'
], 400);
}