br0kenpixel/ReZygisk
1
0
Fork 0
mirror of https://github.com/PerformanC/ReZygisk.git synced 2025-09-06 06:37:01 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

fix: FORCE_DENYLIST_UNMOUNT not forcing umount

Browse Source 
This commit fixes the issue where because the mount namespace switch happened only before the Zygisk modules execution, they wouldn't have the opportunity to set "FORCE_DENYLIST_UNMOUNT" flag. Now, with this commit, which added another check to know if that flag was set by a Zygisk module, and if so, switched to mount namespace, adjusts the behavior to the expected one.
This commit is contained in:
ThePedroo
2025-06-22 18:33:10 -03:00
parent 6c05527ffa
commit fa9adcf3b5
1 changed files with 27 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
loader/src/injector/hook.cpp
View File

@@ -753,12 +753,20 @@ void ZygiskContext::app_specialize_pre() {
} }
/* INFO: Modules only have two "start off" points from Zygisk, preSpecialize and /* INFO: Modules only have two "start off" points from Zygisk, preSpecialize and
postSpecialize. While preSpecialie in fact runs with Zygote (not superuser) postSpecialize. In preSpecialize, the process still has privileged
privileges, in postSpecialize it will now be with lower permission, in permissions, and therefore can execute mount/umount/setns functions.
the app's sandbox and therefore can move to a clean mount namespace after If we update the mount namespace AFTER executing them, any mounts made
executing the modules preSpecialize. will be lost, and the process will not have access to them anymore.
In postSpecialize, while still could have its mounts modified with the
assistance of a Zygisk companion, it will already have the mount
namespace switched by then, so there won't be issues.
Knowing this, we update the mns before execution, so that they can still
make changes to mounts in DenyListed processes without being reverted.
*/ */
if ((info_flags & PROCESS_ON_DENYLIST) == PROCESS_ON_DENYLIST) { bool in_denylist = (info_flags & PROCESS_ON_DENYLIST) == PROCESS_ON_DENYLIST;
if (in_denylist) {
flags[DO_REVERT_UNMOUNT] = true; flags[DO_REVERT_UNMOUNT] = true;
update_mnt_ns(Clean, false); update_mnt_ns(Clean, false);
@@ -768,6 +776,17 @@ void ZygiskContext::app_specialize_pre() {
application without worrying about it being overwritten by setns. application without worrying about it being overwritten by setns.
*/ */
run_modules_pre(); run_modules_pre();
/* INFO: The modules may request that although the process is NOT in
the DenyList, it has its mount namespace switched to the clean
one.
So to ensure this behavior happens, we must also check after the
modules are loaded and executed, so that the modules can have
the chance to request it.
*/
if (!in_denylist && flags[DO_REVERT_UNMOUNT])
update_mnt_ns(Clean, false);
} }
} }