br0kenpixel/ReZygisk
1
0
Fork 0
mirror of https://github.com/PerformanC/ReZygisk.git synced 2025-09-06 06:37:01 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

improve: Zygiskd Magisk code

Browse Source 
This commit improves the Zygiskd Magisk code by avoiding redundant code and reducing complexity.
This commit is contained in:
ThePedroo
2024-11-08 17:21:26 -03:00
parent 3265bcb581
commit a6124a6a5e
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
zygiskd/src/root_impl/magisk.c
View File

@@ -134,7 +134,8 @@ bool magisk_uid_should_umount(uid_t uid) {
LOGE("Failed to execute pm binary: %s\n", strerror(errno)); LOGE("Failed to execute pm binary: %s\n", strerror(errno));
errno = 0; errno = 0;
return false; /* INFO: It's better if we do NOT umount than the opposite */ /* INFO: It's better if we do NOT umount than the opposite */
return false;
} }
if (result[0] == '\0') { if (result[0] == '\0') {
@@ -150,7 +151,6 @@ bool magisk_uid_should_umount(uid_t uid) {
char *const argv[] = { "magisk", "--sqlite", sqlite_cmd, NULL }; char *const argv[] = { "magisk", "--sqlite", sqlite_cmd, NULL };
result[0] = '\0';
if (!exec_command(result, sizeof(result), (const char *)path_to_magisk, argv)) { if (!exec_command(result, sizeof(result), (const char *)path_to_magisk, argv)) {
LOGE("Failed to execute magisk binary: %s\n", strerror(errno)); LOGE("Failed to execute magisk binary: %s\n", strerror(errno));
errno = 0; errno = 0;
@@ -162,12 +162,9 @@ bool magisk_uid_should_umount(uid_t uid) {
} }
bool magisk_uid_is_manager(uid_t uid) { bool magisk_uid_is_manager(uid_t uid) {
char sqlite_cmd[256]; char *const argv[] = { "magisk", "--sqlite", "select value from strings where key=\"requester\" limit 1", NULL };
snprintf(sqlite_cmd, sizeof(sqlite_cmd), "select value from strings where key=\"requester\" limit 1");
char *const argv[] = { "magisk", "--sqlite", sqlite_cmd, NULL }; char output[128];
char output[128] = { 0 };
if (!exec_command(output, sizeof(output), (const char *)path_to_magisk, argv)) { if (!exec_command(output, sizeof(output), (const char *)path_to_magisk, argv)) {
LOGE("Failed to execute magisk binary: %s\n", strerror(errno)); LOGE("Failed to execute magisk binary: %s\n", strerror(errno));
errno = 0; errno = 0;