Updated settings item location >in code<

2025-09-06 06:36:58 +00:00 · 2019-12-06 15:39:12 +01:00
parent 37677f389c
commit 8a03c366b8
9 changed files with 221 additions and 214 deletions
@@ -218,6 +218,6 @@ abstract class ObservableItem<T> : ComparableRvItem<T>(), Observable {
        list.add(callback ?: return)
    }

-    protected fun notifyChange(id: Int) = list.notifyChange(this, id)
+    fun notifyChange(id: Int) = list.notifyChange(this, id)

 }
@@ -0,0 +1,209 @@
+package com.topjohnwu.magisk.model.entity.recycler
+
+import android.content.Context
+import android.content.res.Resources
+import android.view.MotionEvent
+import android.view.View
+import androidx.annotation.CallSuper
+import androidx.databinding.Bindable
+import androidx.databinding.ViewDataBinding
+import androidx.recyclerview.widget.StaggeredGridLayoutManager
+import com.topjohnwu.magisk.BR
+import com.topjohnwu.magisk.R
+import com.topjohnwu.magisk.utils.TransitiveText
+import com.topjohnwu.magisk.view.MagiskDialog
+import org.koin.core.KoinComponent
+import org.koin.core.get
+import kotlin.properties.ObservableProperty
+import kotlin.reflect.KProperty
+
+sealed class SettingsItem : ObservableItem<SettingsItem>() {
+
+    @Bindable
+    open val icon: Int = 0
+    @Bindable
+    open val title: TransitiveText = TransitiveText.empty
+    @Bindable
+    open val description: TransitiveText = TransitiveText.empty
+
+    var isEnabled = true
+        @Bindable get
+        set(value) {
+            field = value
+            notifyChange(BR.enabled)
+        }
+
+    protected open val isFullSpan: Boolean = false
+
+    @CallSuper
+    open fun onPressed(view: View, callback: Callback) {
+        callback.onItemChanged(view, this)
+
+        // notify only after the callback invocation; callback can invalidate the backing data,
+        // which wouldn't be recognized with reverse approach
+        notifyChange(BR.icon)
+        notifyChange(BR.title)
+        notifyChange(BR.description)
+    }
+
+    open fun refresh() {}
+
+    override fun onBindingBound(binding: ViewDataBinding) {
+        super.onBindingBound(binding)
+        if (isFullSpan) {
+            val params = binding.root.layoutParams as? StaggeredGridLayoutManager.LayoutParams
+            params?.isFullSpan = true
+        }
+    }
+
+    override fun itemSameAs(other: SettingsItem) = this === other
+    override fun contentSameAs(other: SettingsItem) = itemSameAs(other)
+
+    // ---
+
+    interface Callback {
+        fun onItemPressed(view: View, item: SettingsItem)
+        fun onItemChanged(view: View, item: SettingsItem)
+    }
+
+    // ---
+
+    abstract class Value<T> : SettingsItem() {
+
+        abstract var value: T
+            @Bindable get
+
+        protected inline fun dataObservable(
+            initialValue: T,
+            crossinline setter: (T) -> Unit
+        ) = object : ObservableProperty<T>(initialValue) {
+            override fun afterChange(property: KProperty<*>, oldValue: T, newValue: T) {
+                setter(newValue)
+                notifyChange(BR.value)
+            }
+        }
+
+    }
+
+    abstract class Toggle : Value<Boolean>() {
+
+        override val layoutRes = R.layout.item_settings_toggle
+
+        override fun onPressed(view: View, callback: Callback) {
+            callback.onItemPressed(view, this)
+            value = !value
+            super.onPressed(view, callback)
+        }
+
+        fun onTouched(view: View, callback: Callback, event: MotionEvent): Boolean {
+            if (event.action == MotionEvent.ACTION_UP) {
+                onPressed(view, callback)
+            }
+            return true
+        }
+
+    }
+
+    abstract class Input : Value<String>(), KoinComponent {
+
+        override val layoutRes = R.layout.item_settings_input
+        open val showStrip = true
+
+        protected val resources get() = get<Resources>()
+        protected abstract val intermediate: String?
+
+        override fun onPressed(view: View, callback: Callback) {
+            callback.onItemPressed(view, this)
+            MagiskDialog(view.context)
+                .applyTitle(title.getText(resources))
+                .applyView(getView(view.context))
+                .applyButton(MagiskDialog.ButtonType.POSITIVE) {
+                    titleRes = android.R.string.ok
+                    onClick {
+                        intermediate?.let { result ->
+                            preventDismiss = false
+                            value = result
+                            it.dismiss()
+                            super.onPressed(view, callback)
+                            return@onClick
+                        }
+                        preventDismiss = true
+                    }
+                }
+                .applyButton(MagiskDialog.ButtonType.NEGATIVE) {
+                    titleRes = android.R.string.cancel
+                }
+                .reveal()
+        }
+
+        abstract fun getView(context: Context): View
+
+    }
+
+    abstract class Selector : Value<Int>(), KoinComponent {
+
+        override val layoutRes = R.layout.item_settings_selector
+
+        protected val resources get() = get<Resources>()
+
+        @Bindable
+        var entries: Array<out CharSequence> = arrayOf()
+            private set
+        @Bindable
+        var entryValues: Array<out CharSequence> = arrayOf()
+            private set
+
+        val selectedEntry
+            @Bindable get() = entries.getOrNull(value)
+
+        fun setValues(
+            entries: Array<out CharSequence>,
+            values: Array<out CharSequence>
+        ) {
+            check(entries.size <= values.size) { "List sizes must match" }
+
+            this.entries = entries
+            this.entryValues = values
+
+            notifyChange(BR.entries)
+            notifyChange(BR.entryValues)
+            notifyChange(BR.selectedEntry)
+        }
+
+        override fun onPressed(view: View, callback: Callback) {
+            if (entries.isEmpty() || entryValues.isEmpty()) return
+            callback.onItemPressed(view, this)
+            MagiskDialog(view.context)
+                .applyTitle(title.getText(resources))
+                .applyButton(MagiskDialog.ButtonType.NEGATIVE) {
+                    titleRes = android.R.string.cancel
+                }
+                .applyAdapter(entries) {
+                    value = it
+                    notifyChange(BR.selectedEntry)
+                    super.onPressed(view, callback)
+                }
+                .reveal()
+        }
+
+    }
+
+    abstract class Blank : SettingsItem() {
+
+        override val layoutRes = R.layout.item_settings_blank
+
+        override fun onPressed(view: View, callback: Callback) {
+            callback.onItemPressed(view, this)
+            super.onPressed(view, callback)
+        }
+
+    }
+
+    abstract class Section : SettingsItem() {
+
+        override val layoutRes = R.layout.item_settings_section
+        override val isFullSpan = true
+
+    }
+
+}