Cleanup and move things around

app/src/main/java/com/topjohnwu/magisk/ktx/XAndroid.kt

@@ -11,7 +11,6 @@ import android.content.pm.PackageInfo
 import android.content.pm.PackageManager
 import android.content.pm.PackageManager.PERMISSION_GRANTED
 import android.content.res.Configuration
-import android.database.Cursor
 import android.graphics.Bitmap
 import android.graphics.Canvas
 import android.graphics.drawable.AdaptiveIconDrawable
@@ -22,12 +21,10 @@ import android.os.Build.VERSION.SDK_INT
 import android.os.Process
 import android.view.View
 import android.view.ViewGroup
-import android.view.ViewTreeObserver
 import android.view.inputmethod.InputMethodManager
 import androidx.appcompat.content.res.AppCompatResources
 import androidx.core.content.ContextCompat
 import androidx.core.content.getSystemService
-import androidx.fragment.app.Fragment
 import androidx.interpolator.view.animation.FastOutSlowInInterpolator
 import androidx.transition.AutoTransition
 import androidx.transition.TransitionManager
@@ -35,7 +32,6 @@ import com.topjohnwu.magisk.R
 import com.topjohnwu.magisk.core.Const
 import com.topjohnwu.magisk.core.utils.RootUtils
 import com.topjohnwu.magisk.core.utils.currentLocale
-import com.topjohnwu.magisk.utils.DynamicClassLoader
 import com.topjohnwu.superuser.Shell
 import java.io.File
 import kotlin.Array
@@ -172,12 +168,6 @@ fun Intent.toCommand(args: MutableList<String> = mutableListOf()): MutableList<S
 
 fun Context.cachedFile(name: String) = File(cacheDir, name)
 
-fun <Result> Cursor.toList(transformer: (Cursor) -> Result): List<Result> {
-    val out = mutableListOf<Result>()
-    while (moveToNext()) out.add(transformer(this))
-    return out
-}
-
 fun ApplicationInfo.getLabel(pm: PackageManager): String {
     runCatching {
         if (labelRes > 0) {
@@ -192,9 +182,6 @@ fun ApplicationInfo.getLabel(pm: PackageManager): String {
     return loadLabel(pm).toString()
 }
 
-inline fun <reified T> T.createClassLoader(apk: File) =
-    DynamicClassLoader(apk, T::class.java.classLoader)
-
 fun Context.unwrap(): Context {
     var context = this
     while (true) {
@@ -217,21 +204,6 @@ fun Activity.hideKeyboard() {
     view.clearFocus()
 }
 
-fun Fragment.hideKeyboard() {
-    activity?.hideKeyboard()
-}
-
-fun View.setOnViewReadyListener(callback: () -> Unit) = addOnGlobalLayoutListener(true, callback)
-
-fun View.addOnGlobalLayoutListener(oneShot: Boolean = false, callback: () -> Unit) =
-    viewTreeObserver.addOnGlobalLayoutListener(object :
-        ViewTreeObserver.OnGlobalLayoutListener {
-        override fun onGlobalLayout() {
-            if (oneShot) viewTreeObserver.removeOnGlobalLayoutListener(this)
-            callback()
-        }
-    })
-
 fun ViewGroup.startAnimations() {
     val transition = AutoTransition()
         .setInterpolator(FastOutSlowInInterpolator())

app/src/main/java/com/topjohnwu/magisk/ktx/XBinding.kt

@@ -1,65 +0,0 @@
-package com.topjohnwu.magisk.ktx
-
-import androidx.databinding.ObservableList
-
-fun <T> ObservableList<T>.addOnListChangedCallback(
-    onChanged: ((sender: ObservableList<T>) -> Unit)? = null,
-    onItemRangeRemoved: ((sender: ObservableList<T>, positionStart: Int, itemCount: Int) -> Unit)? = null,
-    onItemRangeMoved: ((sender: ObservableList<T>, fromPosition: Int, toPosition: Int, itemCount: Int) -> Unit)? = null,
-    onItemRangeInserted: ((sender: ObservableList<T>, positionStart: Int, itemCount: Int) -> Unit)? = null,
-    onItemRangeChanged: ((sender: ObservableList<T>, positionStart: Int, itemCount: Int) -> Unit)? = null
-) = addOnListChangedCallback(object : ObservableList.OnListChangedCallback<ObservableList<T>>() {
-    override fun onChanged(sender: ObservableList<T>?) {
-        onChanged?.invoke(sender ?: return)
-    }
-
-    override fun onItemRangeRemoved(
-        sender: ObservableList<T>?,
-        positionStart: Int,
-        itemCount: Int
-    ) {
-        onItemRangeRemoved?.invoke(
-            sender ?: return,
-            positionStart,
-            itemCount
-        )
-    }
-
-    override fun onItemRangeMoved(
-        sender: ObservableList<T>?,
-        fromPosition: Int,
-        toPosition: Int,
-        itemCount: Int
-    ) {
-        onItemRangeMoved?.invoke(
-            sender ?: return,
-            fromPosition,
-            toPosition,
-            itemCount
-        )
-    }
-
-    override fun onItemRangeInserted(
-        sender: ObservableList<T>?,
-        positionStart: Int,
-        itemCount: Int
-    ) {
-        onItemRangeInserted?.invoke(
-            sender ?: return,
-            positionStart,
-            itemCount
-        )
-    }
-
-    override fun onItemRangeChanged(
-        sender: ObservableList<T>?,
-        positionStart: Int,
-        itemCount: Int
-    ) {
-        onItemRangeChanged?.invoke(
-            sender ?: return,
-            positionStart,
-            itemCount
-        )
-    }
-})

app/src/main/java/com/topjohnwu/magisk/ktx/XFlow.kt

@@ -1,11 +0,0 @@
-package com.topjohnwu.magisk.ktx
-
-import kotlinx.coroutines.flow.Flow
-import kotlinx.coroutines.flow.flatMapMerge
-import kotlinx.coroutines.flow.flow
-
-inline fun <T, R> Flow<T>.concurrentMap(crossinline transform: suspend (T) -> R): Flow<R> {
-    return flatMapMerge { value ->
-        flow { emit(transform(value)) }
-    }
-}

app/src/main/java/com/topjohnwu/magisk/ktx/XJVM.kt

@@ -1,11 +1,15 @@
 package com.topjohnwu.magisk.ktx
 
 import androidx.collection.SparseArrayCompat
-import timber.log.Timber
+import com.topjohnwu.magisk.core.utils.currentLocale
+import kotlinx.coroutines.flow.Flow
+import kotlinx.coroutines.flow.flatMapMerge
+import kotlinx.coroutines.flow.flow
 import java.io.File
 import java.io.InputStream
 import java.io.OutputStream
 import java.lang.reflect.Field
+import java.text.DateFormat
 import java.text.SimpleDateFormat
 import java.util.*
 import java.util.zip.ZipEntry
@@ -45,8 +49,27 @@ fun <T> MutableSet<T>.synchronized(): MutableSet<T> = Collections.synchronizedSe
 
 fun <K, V> MutableMap<K, V>.synchronized(): MutableMap<K, V> = Collections.synchronizedMap(this)
 
-fun SimpleDateFormat.parseOrNull(date: String) =
-    runCatching { parse(date) }.onFailure { Timber.e(it) }.getOrNull()
-
 fun Class<*>.reflectField(name: String): Field =
     getDeclaredField(name).apply { isAccessible = true }
+
+inline fun <T, R> Flow<T>.concurrentMap(crossinline transform: suspend (T) -> R): Flow<R> {
+    return flatMapMerge { value ->
+        flow { emit(transform(value)) }
+    }
+}
+
+fun Long.toTime(format: DateFormat) = format.format(this).orEmpty()
+
+val timeFormatStandard by lazy {
+    SimpleDateFormat(
+        "yyyy-MM-dd'T'HH:mm:ss",
+        currentLocale
+    )
+}
+val timeDateFormat: DateFormat by lazy {
+    DateFormat.getDateTimeInstance(
+        DateFormat.DEFAULT,
+        DateFormat.DEFAULT,
+        currentLocale
+    )
+}

app/src/main/java/com/topjohnwu/magisk/ktx/XTime.kt

@@ -1,21 +0,0 @@
-package com.topjohnwu.magisk.ktx
-
-import com.topjohnwu.magisk.core.utils.currentLocale
-import java.text.DateFormat
-import java.text.SimpleDateFormat
-
-val now get() = System.currentTimeMillis()
-
-fun Long.toTime(format: DateFormat) = format.format(this).orEmpty()
-
-val timeFormatStandard by lazy { SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss",
-    currentLocale
-) }
-
-val timeDateFormat: DateFormat by lazy {
-    DateFormat.getDateTimeInstance(
-        DateFormat.DEFAULT,
-        DateFormat.DEFAULT,
-        currentLocale
-    )
-}