Modernize Repo class for Magisk modules

- Use Kotlin
- Use Room database
- Use retrofit for networking
- Use RxJava pipeline for repo updating

app/src/main/java/com/topjohnwu/magisk/ui/module/ModuleViewModel.kt

@@ -9,18 +9,16 @@ import com.skoumal.teanity.util.DiffObservableList
 import com.skoumal.teanity.util.KObservableField
 import com.topjohnwu.magisk.BR
 import com.topjohnwu.magisk.R
-import com.topjohnwu.magisk.data.database.RepoDatabaseHelper
-import com.topjohnwu.magisk.model.entity.Module
-import com.topjohnwu.magisk.model.entity.Repo
+import com.topjohnwu.magisk.data.database.RepoDao
+import com.topjohnwu.magisk.model.entity.module.Module
 import com.topjohnwu.magisk.model.entity.recycler.ModuleRvItem
 import com.topjohnwu.magisk.model.entity.recycler.RepoRvItem
 import com.topjohnwu.magisk.model.entity.recycler.SectionRvItem
 import com.topjohnwu.magisk.model.events.InstallModuleEvent
 import com.topjohnwu.magisk.model.events.OpenChangelogEvent
 import com.topjohnwu.magisk.model.events.OpenFilePickerEvent
-import com.topjohnwu.magisk.tasks.UpdateRepos
+import com.topjohnwu.magisk.tasks.RepoUpdater
 import com.topjohnwu.magisk.ui.base.MagiskViewModel
-import com.topjohnwu.magisk.utils.toList
 import com.topjohnwu.magisk.utils.toSingle
 import com.topjohnwu.magisk.utils.update
 import io.reactivex.Single
@@ -28,9 +26,9 @@ import io.reactivex.disposables.Disposable
 import me.tatarka.bindingcollectionadapter2.OnItemBind
 
 class ModuleViewModel(
-        private val resources: Resources,
-        private val repoDatabase: RepoDatabaseHelper,
-        private val repoUpdater: UpdateRepos
+    private val resources: Resources,
+    private val repoUpdater: RepoUpdater,
+    private val repoDB: RepoDao
 ) : MagiskViewModel() {
 
     val query = KObservableField("")
@@ -65,9 +63,10 @@ class ModuleViewModel(
             .toList()
             .map { it to itemsInstalled.calculateDiff(it) }
             .doOnSuccessUi { itemsInstalled.update(it.first, it.second) }
-            .flatMap { repoUpdater.exec(force) }
-            .flatMap { Single.fromCallable { repoDatabase.repoCursor.toList { Repo(it) } } }
-            .flattenAsFlowable { it }
+            .toFlowable()
+            .flatMap { repoUpdater(force) }
+            .collect({}, {_, _ -> })
+            .flattenAsFlowable { repoDB.repos }
             .map { RepoRvItem(it) }
             .toList()
             .doOnSuccess { allItems.update(it) }

app/src/main/java/com/topjohnwu/magisk/ui/module/ReposFragment.kt

@@ -11,7 +11,7 @@ import com.topjohnwu.magisk.Config
 import com.topjohnwu.magisk.R
 import com.topjohnwu.magisk.databinding.FragmentReposBinding
 import com.topjohnwu.magisk.model.download.DownloadService
-import com.topjohnwu.magisk.model.entity.Repo
+import com.topjohnwu.magisk.model.entity.module.Repo
 import com.topjohnwu.magisk.model.entity.internal.Configuration
 import com.topjohnwu.magisk.model.entity.internal.DownloadSubject
 import com.topjohnwu.magisk.model.events.InstallModuleEvent
@@ -89,7 +89,7 @@ class ReposFragment : MagiskFragment<ModuleViewModel, FragmentReposBinding>(),
     }
 
     private fun openChangelog(item: Repo) {
-        MarkDownWindow.show(requireActivity(), null, item.detailUrl)
+        MarkDownWindow.show(requireActivity(), null, item.readme)
     }
 
     @SuppressLint("MissingPermission")

app/src/main/java/com/topjohnwu/magisk/ui/settings/SettingsFragment.kt

@@ -8,7 +8,6 @@ import android.view.LayoutInflater
 import android.widget.EditText
 import android.widget.Toast
 import androidx.appcompat.app.AlertDialog
-import androidx.core.content.edit
 import androidx.databinding.DataBindingUtil
 import androidx.preference.ListPreference
 import androidx.preference.Preference
@@ -20,7 +19,7 @@ import com.topjohnwu.magisk.BuildConfig
 import com.topjohnwu.magisk.Config
 import com.topjohnwu.magisk.Const
 import com.topjohnwu.magisk.R
-import com.topjohnwu.magisk.data.database.RepoDatabaseHelper
+import com.topjohnwu.magisk.data.database.RepoDao
 import com.topjohnwu.magisk.databinding.CustomDownloadDialogBinding
 import com.topjohnwu.magisk.model.observer.Observer
 import com.topjohnwu.magisk.ui.base.BasePreferenceFragment
@@ -33,7 +32,7 @@ import java.io.File
 
 class SettingsFragment : BasePreferenceFragment() {
 
-    private val repoDatabase: RepoDatabaseHelper by inject()
+    private val repoDB: RepoDao by inject()
 
     private lateinit var updateChannel: ListPreference
     private lateinit var autoRes: ListPreference
@@ -76,10 +75,7 @@ class SettingsFragment : BasePreferenceFragment() {
             true
         }
         findPreference("clear").setOnPreferenceClickListener {
-            prefs.edit {
-                remove(Config.Key.ETAG_KEY)
-            }
-            repoDatabase.clearRepo()
+            repoDB.clear()
             Utils.toast(R.string.repo_cache_cleared, Toast.LENGTH_SHORT)
             true
         }