Modernize Repo class for Magisk modules

- Use Kotlin
- Use Room database
- Use retrofit for networking
- Use RxJava pipeline for repo updating

app/src/main/java/com/topjohnwu/magisk/data/database/RepoDao.kt

@@ -0,0 +1,70 @@
+package com.topjohnwu.magisk.data.database
+
+import androidx.room.*
+import com.topjohnwu.magisk.Config
+import com.topjohnwu.magisk.model.entity.module.Repo
+
+@Dao
+abstract class RepoDao {
+
+    val repoIDSet: Set<String> get() = getRepoID().map { it.id }.toSet()
+
+    val repos: List<Repo> get() = getReposWithOrder(when (Config.repoOrder) {
+            Config.Value.ORDER_NAME -> "name COLLATE NOCASE"
+            Config.Value.ORDER_DATE -> "last_update DESC"
+            else -> ""
+        })
+
+    var etagKey: String
+        set(etag) = addEtagRaw(RepoEtag(0, etag))
+        get() = etagRaw()?.key.orEmpty()
+
+    fun clear() {
+        clearRepos()
+        clearEtag()
+    }
+
+    @Query("SELECT * FROM repos ORDER BY :order")
+    protected abstract fun getReposWithOrder(order: String): List<Repo>
+
+    @Insert(onConflict = OnConflictStrategy.REPLACE)
+    abstract fun addRepo(repo: Repo)
+
+    @Query("SELECT * FROM repos WHERE id = :id")
+    abstract fun getRepo(id: String): Repo?
+
+    @Query("SELECT id FROM repos")
+    protected abstract fun getRepoID(): List<RepoID>
+
+    @Delete
+    abstract fun removeRepo(repo: Repo)
+
+    @Query("DELETE FROM repos WHERE id = :id")
+    abstract fun removeRepo(id: String)
+
+    @Query("DELETE FROM repos WHERE id IN (:idList)")
+    abstract fun removeRepos(idList: List<String>)
+
+    @Query("SELECT * FROM etag")
+    protected abstract fun etagRaw(): RepoEtag?
+
+    @Insert(onConflict = OnConflictStrategy.REPLACE)
+    protected abstract fun addEtagRaw(etag: RepoEtag)
+
+    @Query("DELETE FROM repos")
+    protected abstract fun clearRepos()
+
+    @Query("DELETE FROM etag")
+    protected abstract fun clearEtag()
+}
+
+data class RepoID(
+    @PrimaryKey val id: String
+)
+
+@Entity(tableName = "etag")
+data class RepoEtag(
+    @PrimaryKey val id: Int,
+    val key: String
+)
+

app/src/main/java/com/topjohnwu/magisk/data/database/RepoDatabase.kt

@@ -0,0 +1,11 @@
+package com.topjohnwu.magisk.data.database
+
+import androidx.room.Database
+import androidx.room.RoomDatabase
+import com.topjohnwu.magisk.model.entity.module.Repo
+
+@Database(version = 6, entities = [Repo::class, RepoEtag::class])
+abstract class RepoDatabase : RoomDatabase() {
+
+    abstract fun repoDao() : RepoDao
+}

app/src/main/java/com/topjohnwu/magisk/data/database/RepoDatabaseHelper.kt

@@ -1,109 +0,0 @@
-package com.topjohnwu.magisk.data.database
-
-import android.content.Context
-import android.database.Cursor
-import android.database.sqlite.SQLiteDatabase
-import android.database.sqlite.SQLiteOpenHelper
-import androidx.core.content.edit
-import com.topjohnwu.magisk.Config
-import com.topjohnwu.magisk.model.entity.Repo
-import java.util.*
-
-@Deprecated("")
-class RepoDatabaseHelper
-constructor(context: Context) : SQLiteOpenHelper(context, "repo.db", null, DATABASE_VER) {
-
-    private val mDb: SQLiteDatabase = writableDatabase
-
-    val rawCursor: Cursor
-        @Deprecated("")
-        get() = mDb.query(TABLE_NAME, null, null, null, null, null, null)
-
-    val repoCursor: Cursor
-        @Deprecated("")
-        get() {
-            var orderBy: String? = null
-            when (Config.repoOrder) {
-                Config.Value.ORDER_NAME -> orderBy = "name COLLATE NOCASE"
-                Config.Value.ORDER_DATE -> orderBy = "last_update DESC"
-            }
-            return mDb.query(TABLE_NAME, null, null, null, null, null, orderBy)
-        }
-
-    val repoIDSet: Set<String>
-        @Deprecated("")
-        get() {
-            val set = HashSet<String>(300)
-            mDb.query(TABLE_NAME, null, null, null, null, null, null).use { c ->
-                while (c.moveToNext()) {
-                    set.add(c.getString(c.getColumnIndex("id")))
-                }
-            }
-            return set
-        }
-
-    override fun onCreate(db: SQLiteDatabase) {
-        onUpgrade(db, 0, DATABASE_VER)
-    }
-
-    override fun onUpgrade(db: SQLiteDatabase, oldVersion: Int, newVersion: Int) {
-        if (oldVersion != newVersion) {
-            // Nuke old DB and create new table
-            db.execSQL("DROP TABLE IF EXISTS $TABLE_NAME")
-            db.execSQL(
-                    "CREATE TABLE IF NOT EXISTS " + TABLE_NAME + " " +
-                            "(id TEXT, name TEXT, version TEXT, versionCode INT, " +
-                            "author TEXT, description TEXT, last_update INT, PRIMARY KEY(id))")
-            Config.prefs.edit {
-                remove(Config.Key.ETAG_KEY)
-            }
-        }
-    }
-
-    override fun onDowngrade(db: SQLiteDatabase, oldVersion: Int, newVersion: Int) {
-        onUpgrade(db, 0, DATABASE_VER)
-    }
-
-    @Deprecated("")
-    fun clearRepo() {
-        mDb.delete(TABLE_NAME, null, null)
-    }
-
-
-    @Deprecated("")
-    fun removeRepo(id: String) {
-        mDb.delete(TABLE_NAME, "id=?", arrayOf(id))
-    }
-
-    @Deprecated("")
-    fun removeRepo(repo: Repo) {
-        removeRepo(repo.id)
-    }
-
-    @Deprecated("")
-    fun removeRepo(list: Iterable<String>) {
-        list.forEach {
-            mDb.delete(TABLE_NAME, "id=?", arrayOf(it))
-        }
-    }
-
-    @Deprecated("")
-    fun addRepo(repo: Repo) {
-        mDb.replace(TABLE_NAME, null, repo.contentValues)
-    }
-
-    @Deprecated("")
-    fun getRepo(id: String): Repo? {
-        mDb.query(TABLE_NAME, null, "id=?", arrayOf(id), null, null, null).use { c ->
-            if (c.moveToNext()) {
-                return Repo(c)
-            }
-        }
-        return null
-    }
-
-    companion object {
-        private val DATABASE_VER = 5
-        private val TABLE_NAME = "repos"
-    }
-}

app/src/main/java/com/topjohnwu/magisk/data/network/GithubServices.kt

@@ -2,15 +2,14 @@ package com.topjohnwu.magisk.data.network
 
 import com.topjohnwu.magisk.Const
 import com.topjohnwu.magisk.model.entity.UpdateInfo
+import com.topjohnwu.magisk.tasks.GithubRepoInfo
+import io.reactivex.Flowable
 import io.reactivex.Single
 import okhttp3.ResponseBody
-import retrofit2.http.GET
-import retrofit2.http.Path
-import retrofit2.http.Streaming
-import retrofit2.http.Url
+import retrofit2.adapter.rxjava2.Result
+import retrofit2.http.*
 
-
-interface GithubRawApiServices {
+interface GithubRawServices {
 
     //region topjohnwu/magisk_files
 
@@ -41,6 +40,9 @@ interface GithubRawApiServices {
     @Streaming
     fun fetchInstaller(): Single<ResponseBody>
 
+    @GET("$MAGISK_MODULES/{$MODULE}/master/{$FILE}")
+    fun fetchModuleInfo(@Path(MODULE) id: String, @Path(FILE) file: String): Single<String>
+
     //endregion
 
     /**
@@ -51,6 +53,9 @@ interface GithubRawApiServices {
     @Streaming
     fun fetchFile(@Url url: String): Single<ResponseBody>
 
+    @GET
+    fun fetchString(@Url url: String): Single<String>
+
 
     companion object {
         private const val REVISION = "revision"
@@ -63,4 +68,14 @@ interface GithubRawApiServices {
         private const val MAGISK_MODULES = "Magisk-Modules-Repo"
     }
 
+}
+
+interface GithubApiServices {
+
+    @GET("repos")
+    fun fetchRepos(@Query("page") page: Int,
+                   @Header(Const.Key.IF_NONE_MATCH) etag: String,
+                   @Query("sort") sort: String = "pushed",
+                   @Query("per_page") count: Int = 100): Flowable<Result<List<GithubRepoInfo>>>
+
 }

app/src/main/java/com/topjohnwu/magisk/data/repository/FileRepository.kt

@@ -1,13 +0,0 @@
-package com.topjohnwu.magisk.data.repository
-
-import com.topjohnwu.magisk.data.network.GithubRawApiServices
-
-class FileRepository(
-    private val api: GithubRawApiServices
-) {
-
-    fun downloadFile(url: String) = api.fetchFile(url)
-
-    fun downloadInstaller() = api.fetchInstaller()
-
-}

app/src/main/java/com/topjohnwu/magisk/data/repository/MagiskRepository.kt

@@ -1,12 +1,11 @@
 package com.topjohnwu.magisk.data.repository
 
-import android.content.Context
 import android.content.pm.PackageManager
 import com.topjohnwu.magisk.App
 import com.topjohnwu.magisk.Config
 import com.topjohnwu.magisk.Info
 import com.topjohnwu.magisk.data.database.base.su
-import com.topjohnwu.magisk.data.network.GithubRawApiServices
+import com.topjohnwu.magisk.data.network.GithubRawServices
 import com.topjohnwu.magisk.model.entity.HideAppInfo
 import com.topjohnwu.magisk.model.entity.HideTarget
 import com.topjohnwu.magisk.utils.Utils
@@ -16,9 +15,8 @@ import com.topjohnwu.superuser.Shell
 import io.reactivex.Single
 
 class MagiskRepository(
-    private val context: Context,
-    private val apiRaw: GithubRawApiServices,
-    private val packageManager: PackageManager
+        private val apiRaw: GithubRawServices,
+        private val packageManager: PackageManager
 ) {
 
     fun fetchSafetynet() = apiRaw.fetchSafetynet()

app/src/main/java/com/topjohnwu/magisk/data/repository/StringRepository.kt

@@ -0,0 +1,15 @@
+package com.topjohnwu.magisk.data.repository
+
+import com.topjohnwu.magisk.data.network.GithubRawServices
+import com.topjohnwu.magisk.model.entity.module.Repo
+
+class StringRepository(
+    private val api: GithubRawServices
+) {
+
+    fun getString(url: String) = api.fetchString(url)
+
+    fun getMetadata(repo: Repo) = api.fetchModuleInfo(repo.id, "module.prop")
+
+    fun getReadme(repo: Repo) = api.fetchModuleInfo(repo.id, "README.md")
+}