You've already forked KernelSU
mirror of
https://github.com/tiann/KernelSU.git
synced 2025-08-27 23:46:34 +00:00
ee72b8e106
## Summary
This pull request introduces custom screen transition animations to
enhance the overall user experience during navigation.
The key change is the implementation of a custom slide/fade effect for
navigating from main screens (i.e., screens hosted in the bottom
navigation bar) to detail screens. Transitions between the bottom
navigation bar tabs themselves retain a simple, clean cross-fade effect
to ensure a fast and smooth user interaction.
This PR also addresses the root cause of an issue where custom
animations were being overridden by the navigation library's defaults.
## Root Cause
During implementation, it was discovered that custom transition
animations defined in the `defaultTransitions` parameter of the
`DestinationsNavHost` in `MainActivity` were not being applied. Instead,
a default fade-in/fade-out animation was always present.
The root cause was traced to the `compose-destinations` KSP (Kotlin
Symbol Processing) code generator. By default, the generator creates a
`NavGraphSpec` (e.g., `RootNavGraph.kt`) that includes its own
`defaultTransitions` property. This property, defined at compile-time
within the generated graph object, has a higher precedence than the
`defaultTransitions` parameter supplied to the `DestinationsNavHost`
composable at runtime.
As a result, our intended custom animations were being ignored and
overridden by the generated default.
## Solution
To resolve this precedence issue permanently, this PR adopts the
official configuration method recommended by the `compose-destinations`
library.
- The following KSP argument has been added to the
`app/build.gradle.kts` file:
```kotlin
ksp {
arg("compose-destinations.defaultTransitions", "none")
}
```
- This argument instructs the code generator to omit the
`defaultTransitions` property from the generated `NavGraphSpec`.
- By removing the higher-priority, generated default, the
`defaultTransitions` parameter on `DestinationsNavHost` now functions as
the effective default, allowing our custom animation logic to execute as
intended.
## Animation Logic Details
The new animation logic is conditional and defined within
`MainActivity`. It distinguishes between two primary navigation types:
- Main Screen → Detail Screen:
- Enter: The new detail screen slides in from the right.
- Exit: The old main screen slides out to the left while fading out.
- Detail Screen → Main Screen (on Pop):
- Pop Enter: The main screen slides back in from the left while fading
in.
- Pop Exit: The detail screen slides out to the right.
- Between Bottom Navigation Tabs:
- A simple cross-fade (`fadeIn`/`fadeOut`) is maintained for these
transitions to provide a quick and non-disruptive experience when
switching between primary sections of the app.
140 lines
4.0 KiB
Plaintext
140 lines
4.0 KiB
Plaintext
@file:Suppress("UnstableApiUsage")
|
|
|
|
import com.android.build.gradle.internal.api.BaseVariantOutputImpl
|
|
import com.android.build.gradle.tasks.PackageAndroidArtifact
|
|
|
|
plugins {
|
|
alias(libs.plugins.agp.app)
|
|
alias(libs.plugins.kotlin)
|
|
alias(libs.plugins.compose.compiler)
|
|
alias(libs.plugins.ksp)
|
|
alias(libs.plugins.lsplugin.apksign)
|
|
id("kotlin-parcelize")
|
|
}
|
|
|
|
val managerVersionCode: Int by rootProject.extra
|
|
val managerVersionName: String by rootProject.extra
|
|
|
|
apksign {
|
|
storeFileProperty = "KEYSTORE_FILE"
|
|
storePasswordProperty = "KEYSTORE_PASSWORD"
|
|
keyAliasProperty = "KEY_ALIAS"
|
|
keyPasswordProperty = "KEY_PASSWORD"
|
|
}
|
|
|
|
android {
|
|
namespace = "me.weishu.kernelsu"
|
|
|
|
buildTypes {
|
|
release {
|
|
isMinifyEnabled = true
|
|
isShrinkResources = true
|
|
proguardFiles(getDefaultProguardFile("proguard-android-optimize.txt"), "proguard-rules.pro")
|
|
}
|
|
}
|
|
|
|
buildFeatures {
|
|
aidl = true
|
|
buildConfig = true
|
|
compose = true
|
|
prefab = true
|
|
}
|
|
|
|
kotlinOptions {
|
|
jvmTarget = "21"
|
|
}
|
|
|
|
packaging {
|
|
jniLibs {
|
|
useLegacyPackaging = true
|
|
}
|
|
resources {
|
|
// https://stackoverflow.com/a/58956288
|
|
// It will break Layout Inspector, but it's unused for release build.
|
|
excludes += "META-INF/*.version"
|
|
// https://github.com/Kotlin/kotlinx.coroutines?tab=readme-ov-file#avoiding-including-the-debug-infrastructure-in-the-resulting-apk
|
|
excludes += "DebugProbesKt.bin"
|
|
// https://issueantenna.com/repo/kotlin/kotlinx.coroutines/issues/3158
|
|
excludes += "kotlin-tooling-metadata.json"
|
|
}
|
|
}
|
|
|
|
externalNativeBuild {
|
|
cmake {
|
|
path("src/main/cpp/CMakeLists.txt")
|
|
}
|
|
}
|
|
|
|
applicationVariants.all {
|
|
outputs.forEach {
|
|
val output = it as BaseVariantOutputImpl
|
|
output.outputFileName = "KernelSU_${managerVersionName}_${managerVersionCode}-$name.apk"
|
|
}
|
|
kotlin.sourceSets {
|
|
getByName(name) {
|
|
kotlin.srcDir("build/generated/ksp/$name/kotlin")
|
|
}
|
|
}
|
|
}
|
|
|
|
// https://stackoverflow.com/a/77745844
|
|
tasks.withType<PackageAndroidArtifact> {
|
|
doFirst { appMetadata.asFile.orNull?.writeText("") }
|
|
}
|
|
|
|
dependenciesInfo {
|
|
includeInApk = false
|
|
includeInBundle = false
|
|
}
|
|
|
|
androidResources {
|
|
generateLocaleConfig = true
|
|
}
|
|
}
|
|
|
|
ksp {
|
|
arg("compose-destinations.defaultTransitions", "none")
|
|
}
|
|
|
|
dependencies {
|
|
implementation(libs.androidx.activity.compose)
|
|
implementation(libs.androidx.navigation.compose)
|
|
|
|
implementation(platform(libs.androidx.compose.bom))
|
|
implementation(libs.androidx.compose.material.icons.extended)
|
|
implementation(libs.androidx.compose.material)
|
|
implementation(libs.androidx.compose.material3)
|
|
implementation(libs.androidx.compose.ui)
|
|
implementation(libs.androidx.compose.ui.tooling.preview)
|
|
|
|
debugImplementation(libs.androidx.compose.ui.test.manifest)
|
|
debugImplementation(libs.androidx.compose.ui.tooling)
|
|
|
|
implementation(libs.androidx.lifecycle.runtime.compose)
|
|
implementation(libs.androidx.lifecycle.runtime.ktx)
|
|
implementation(libs.androidx.lifecycle.viewmodel.compose)
|
|
|
|
implementation(libs.compose.destinations.core)
|
|
ksp(libs.compose.destinations.ksp)
|
|
|
|
implementation(libs.com.github.topjohnwu.libsu.core)
|
|
implementation(libs.com.github.topjohnwu.libsu.service)
|
|
implementation(libs.com.github.topjohnwu.libsu.io)
|
|
|
|
implementation(libs.dev.rikka.rikkax.parcelablelist)
|
|
|
|
implementation(libs.io.coil.kt.coil.compose)
|
|
|
|
implementation(libs.kotlinx.coroutines.core)
|
|
|
|
implementation(libs.me.zhanghai.android.appiconloader.coil)
|
|
|
|
implementation(libs.sheet.compose.dialogs.core)
|
|
implementation(libs.sheet.compose.dialogs.list)
|
|
implementation(libs.sheet.compose.dialogs.input)
|
|
|
|
implementation(libs.markdown)
|
|
implementation(libs.androidx.webkit)
|
|
|
|
implementation(libs.lsposed.cxx)
|
|
} |