From f439ff625ce22e03db22210cb1c74c1e0c0ea815 Mon Sep 17 00:00:00 2001 From: silvzr <117378129+silvzr@users.noreply.github.com> Date: Sat, 21 Dec 2024 03:49:44 +0600 Subject: [PATCH] manager: Avoid unecessary function calls in Home.kt the install function is called everytime you go to the HomeScreen, move it to MainActivity instead so it's executed on app launch only. --- .../src/main/java/com/rifsxd/ksunext/ui/MainActivity.kt | 4 ++++ .../app/src/main/java/com/rifsxd/ksunext/ui/screen/Home.kt | 7 ------- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/manager/app/src/main/java/com/rifsxd/ksunext/ui/MainActivity.kt b/manager/app/src/main/java/com/rifsxd/ksunext/ui/MainActivity.kt index 5ea6d895..cd26311c 100644 --- a/manager/app/src/main/java/com/rifsxd/ksunext/ui/MainActivity.kt +++ b/manager/app/src/main/java/com/rifsxd/ksunext/ui/MainActivity.kt @@ -45,6 +45,7 @@ import com.rifsxd.ksunext.ui.screen.BottomBarDestination import com.rifsxd.ksunext.ui.theme.KernelSUTheme import com.rifsxd.ksunext.ui.util.LocalSnackbarHost import com.rifsxd.ksunext.ui.util.rootAvailable +import com.rifsxd.ksunext.ui.util.install class MainActivity : ComponentActivity() { @@ -58,6 +59,9 @@ class MainActivity : ComponentActivity() { super.onCreate(savedInstanceState) + val isManager = Natives.becomeManager(ksuApp.packageName) + if (isManager) install() + setContent { KernelSUTheme { val navController = rememberNavController() diff --git a/manager/app/src/main/java/com/rifsxd/ksunext/ui/screen/Home.kt b/manager/app/src/main/java/com/rifsxd/ksunext/ui/screen/Home.kt index 9c9b1e0f..3738d19e 100644 --- a/manager/app/src/main/java/com/rifsxd/ksunext/ui/screen/Home.kt +++ b/manager/app/src/main/java/com/rifsxd/ksunext/ui/screen/Home.kt @@ -70,13 +70,6 @@ fun HomeScreen(navigator: DestinationsNavigator) { verticalArrangement = Arrangement.spacedBy(16.dp) ) { val isManager = Natives.becomeManager(ksuApp.packageName) - SideEffect { - if (isManager) { - Handler(Looper.getMainLooper()).postDelayed({ - install() - }, 2000) - } - } val ksuVersion = if (isManager) Natives.version else null val lkmMode = ksuVersion?.let { if (it >= Natives.MINIMAL_SUPPORTED_KERNEL_LKM && kernelVersion.isGKI()) Natives.isLkmMode else null