br0kenpixel/KernelSU-Next
1
0
Fork 0
mirror of https://github.com/KernelSU-Next/KernelSU-Next.git synced 2025-08-27 23:46:34 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

ksud_overlayfs: better hide modules.img (create a sparse image without journaling) and run e2fsck for eliminating possible data corruption after umount

Browse Source
This commit is contained in:
rifsxd
2025-02-15 18:40:46 +06:00
parent fe9578433c
commit aa22fd880d
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
userspace/ksud_overlayfs/src/module.rs
View File

@@ -284,16 +284,16 @@ pub fn prune_modules() -> Result<()> {
Ok(()) Ok(())
} }
fn create_module_image(image: &str, image_size: u64, journal_size: u64) -> Result<()> { fn create_module_image(image: &str, image_size: u64) -> Result<()> {
File::create(image) File::create(image)
.context("Failed to create ext4 image file")? .context("Failed to create ext4 image file")?
.set_len(image_size) .set_len(image_size)
.context("Failed to truncate ext4 image")?; .context("Failed to truncate ext4 image")?;
// format the img to ext4 filesystem // format the img to ext4 filesystem without journal
let result = Command::new("mkfs.ext4") let result = Command::new("mkfs.ext4")
.arg("-J") .arg("-O")
.arg(format!("size={journal_size}")) .arg("^has_journal")
.arg(image) .arg(image)
.stdout(Stdio::piped()) .stdout(Stdio::piped())
.output()?; .output()?;
@@ -365,12 +365,11 @@ fn _install_module(zip: &str) -> Result<()> {
); );
let sparse_image_size = 6 << 30; // 6GB let sparse_image_size = 6 << 30; // 6GB
let journal_size = 8; // 8MB
if !modules_img_exist && !modules_update_img_exist { if !modules_img_exist && !modules_update_img_exist {
// if no modules and modules_update, it is brand new installation, we should create a new img // if no modules and modules_update, it is brand new installation, we should create a new img
// create a tmp module img and mount it to modules_update // create a tmp module img and mount it to modules_update
info!("Creating brand new module image"); info!("Creating brand new module image");
create_module_image(tmp_module_img, sparse_image_size, journal_size)?; create_module_image(tmp_module_img, sparse_image_size)?;
} else if modules_update_img_exist { } else if modules_update_img_exist {
// modules_update.img exists, we should use it as tmp img // modules_update.img exists, we should use it as tmp img
info!("Using existing modules_update.img as tmp image"); info!("Using existing modules_update.img as tmp image");
@@ -392,7 +391,7 @@ fn _install_module(zip: &str) -> Result<()> {
// legacy image, it's block size is 1024 with unlimited journal size // legacy image, it's block size is 1024 with unlimited journal size
if blksize == 1024 { if blksize == 1024 {
println!("- Legacy image, migrating to new format, please be patient..."); println!("- Legacy image, migrating to new format, please be patient...");
create_module_image(tmp_module_img, sparse_image_size, journal_size)?; create_module_image(tmp_module_img, sparse_image_size)?;
let _dontdrop = let _dontdrop =
mount::AutoMountExt4::try_new(tmp_module_img, module_update_tmp_dir, true) mount::AutoMountExt4::try_new(tmp_module_img, module_update_tmp_dir, true)
.with_context(|| format!("Failed to mount {tmp_module_img}"))?; .with_context(|| format!("Failed to mount {tmp_module_img}"))?;