br0kenpixel/KernelSU-Next
1
0
Fork 0
mirror of https://github.com/KernelSU-Next/KernelSU-Next.git synced 2025-08-27 23:46:34 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

[BUGFIX] manager: Fix Module Flashing fails when orientation changes (#503)

Browse Source 
The issue is caused by re-rendering of Activity when orientation changes.
All states are reset when it is re-rendered. Using ViewModel to manage zipUri fixes the issue.

Fixes issue: https://github.com/KernelSU-Next/KernelSU-Next/issues/488
This commit is contained in:
Suraj J Pai
2025-06-12 04:14:45 +05:30
committed by GitHub
parent e7697d86fe
commit 7abc9bc821
2 changed files with 20 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
manager/app/src/main/java/com/rifsxd/ksunext/ui/screen/Module.kt
View File

@@ -290,8 +290,11 @@ fun ModuleScreen(navigator: DestinationsNavigator) {
val confirmTitle = stringResource(R.string.module) val confirmTitle = stringResource(R.string.module)
var zipUris by remember { mutableStateOf<List<Uri>>(emptyList()) } var zipUris by remember { mutableStateOf<List<Uri>>(emptyList()) }
val confirmDialog = rememberConfirmDialog(onConfirm = { val confirmDialog = rememberConfirmDialog(onConfirm = {
navigator.navigate(FlashScreenDestination(FlashIt.FlashModules(zipUris))) if (viewModel.zipUris.isNotEmpty()) {
navigator.navigate(FlashScreenDestination(FlashIt.FlashModules(viewModel.zipUris)))
viewModel.clearZipUris()
viewModel.markNeedRefresh() viewModel.markNeedRefresh()
}
}) })
val selectZipLauncher = rememberLauncherForActivityResult( val selectZipLauncher = rememberLauncherForActivityResult(
contract = ActivityResultContracts.StartActivityForResult() contract = ActivityResultContracts.StartActivityForResult()
@@ -311,6 +314,10 @@ fun ModuleScreen(navigator: DestinationsNavigator) {
data.data?.let { uris.add(it) } data.data?.let { uris.add(it) }
} }
if (uris.isEmpty()) return@rememberLauncherForActivityResult
viewModel.updateZipUris(uris)
// Show confirm dialog with selected zip file(s) name(s) // Show confirm dialog with selected zip file(s) name(s)
val moduleNames = val moduleNames =
uris.mapIndexed { index, uri -> "\n${index + 1}. ${uri.getFileName(context)}" } uris.mapIndexed { index, uri -> "\n${index + 1}. ${uri.getFileName(context)}" }

11
manager/app/src/main/java/com/rifsxd/ksunext/ui/viewmodel/ModuleViewModel.kt
View File

@@ -1,5 +1,6 @@
package com.rifsxd.ksunext.ui.viewmodel package com.rifsxd.ksunext.ui.viewmodel
import android.net.Uri
import android.os.SystemClock import android.os.SystemClock
import android.util.Log import android.util.Log
import androidx.compose.runtime.derivedStateOf import androidx.compose.runtime.derivedStateOf
@@ -93,6 +94,16 @@ class ModuleViewModel : ViewModel() {
isNeedRefresh = true isNeedRefresh = true
} }
var zipUris by mutableStateOf<List<Uri>>(emptyList())
fun updateZipUris(uris: List<Uri>) {
zipUris = uris
}
fun clearZipUris() {
zipUris = emptyList()
}
fun fetchModuleList() { fun fetchModuleList() {
viewModelScope.launch { viewModelScope.launch {